Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pods tweaks and features, changes to pods crash chance #3945

Merged
merged 9 commits into from
Jul 25, 2023

Conversation

ihatethisengine
Copy link
Contributor

@ihatethisengine ihatethisengine commented Jul 19, 2023

About the pull request

Xenos can break and acid manually locked pods' doors, but still cannot slash/acid them before evac is called to prevent metagaming. Pod cannot launch without doors. No more delaying in pods.

Early launch has a 75% chance of crash, launch after the evacuation timer (whether manual or automatic) has only 25%.

CL's pod has a 25% chance of crash on early launch and only 5% otherwise.

Explain why it's good for the game

Encourages players to actually play during hijack sequence. You need to live for long enough to have a better chance to evac on pods, but if situation is dire you can still risk it. If you crash, your story continues. Also, no more delayers in pods.

Testing Photographs and Procedure

Screenshots & Videos

Changelog

🆑 ihatethisengine
balance: early pod launch now has a 75% chance of crashing, launch after the timer has a 25% chance.
add: CL's pod has a 25% chance of crashing on early launch and only 5% otherwise.
add: xenos can slash and melt manually locked pod's doors.
/:cl:

@github-actions
Copy link
Contributor

You currently have a negative Fix/Feature pull request delta of -1. Maintainers may close this PR at will. Fixing issues or improving the codebase will improve this score.

@github-actions github-actions bot added Balance You need to be a professional veteran game maintainer to comprehend what is being done here. Feature Feature coder badge labels Jul 19, 2023
Comment on lines 236 to 238
else
to_chat(xeno, SPAN_WARNING("[src] is bolted down tight."))
return XENO_NO_DELAY_ACTION
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

early return

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better now?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh I see

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh I see

@harryob harryob marked this pull request as draft July 22, 2023 12:56
@ihatethisengine ihatethisengine marked this pull request as ready for review July 22, 2023 15:27
Copy link
Member

@harryob harryob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wait im dumb

code/modules/shuttle/shuttles/escape_shuttle.dm Outdated Show resolved Hide resolved
@harryob harryob marked this pull request as draft July 24, 2023 22:13
@harryob harryob marked this pull request as ready for review July 24, 2023 22:14
@harryob harryob enabled auto-merge July 24, 2023 22:14
@harryob harryob added this pull request to the merge queue Jul 24, 2023
Merged via the queue into cmss13-devs:master with commit 6f3b74b Jul 25, 2023
cm13-github added a commit that referenced this pull request Jul 25, 2023
github-actions bot added a commit that referenced this pull request Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Balance You need to be a professional veteran game maintainer to comprehend what is being done here. Feature Feature coder badge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants